pr changes #237
Merged
pr changes #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
approved these changes
Jul 9, 2024
brentyi
added a commit
that referenced
this pull request
Jul 11, 2024
* Add Gaussian splatting implementation Shaders adapted from: https://github.com/antimatter15/splat/ * Optimize * Fix uniform updates, performance improvements * Sync * Implement sort in C++/WebAssembly, 2~3x faster * Rename hack pt 1 * Rename pt 2 * Component lifecycle cleanup * Fix typescript * Fix view error * Account for pixel ratio in point cloud shader * ruff * Experiment * Fix runtime error * Use new websock_interface API * Fix GUI container edge cases, the code needs a refactor 🙂 * 0.2.0 * Signficant performance improvements * ruff * "We have Luma AI at home" * More improvements * Fix bug caught by pyright * Sorting cleanup * More performance tweaks * Cholesky, optimizations, formatting * ruf isues * pr changes (#237) * pr changes * nit --------- Co-authored-by: Brent Yi <[email protected]> * Nits, mark API as explicitly experimental * Address pyright issues * Docs / notes * ruff --------- Co-authored-by: Rebecca Feng <[email protected]> Co-authored-by: beckyfeng08 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified code based on critiques